The 37-year-old nepo baby of Bruce Willis and the 39-year-old former child star were thick as thieves between 2006-2009